Replace user/pass with sessionId after successful login #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--exclude Maybe this caused the failing integration tests? |
|
Indeed this PR causes the integration test failure. I'll close it again. Due to the whole re-connection logic in the gateway it's just not possible to get rid off the password after login. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79 .
After successful login the username and password will be replaced by the sessionId, so that the password is not held in memory any longer. With the sessionId as username/password it is still possible to re-connect after a connection loss without having the password.
It only partially addresses the issue. There's no point in replacing the password String with char[] unless it can be done everywhere in the code. But when calling the Java API the method requires a String anyway.