Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog 0.5.3 #93

Merged
merged 4 commits into from
Nov 27, 2024
Merged

changelog 0.5.3 #93

merged 4 commits into from
Nov 27, 2024

Conversation

will-moore
Copy link
Member

@francesw @jburel I'll get this released and bumped in IDR along with gallery if no objections?

@will-moore
Copy link
Member Author

Oh dear - build failed, not due to this PR I think

#12 21.81  From       : /etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY-RHEL
#12 22.40 Error: Failed to download metadata for repo 'pgdg12': repomd.xml GPG signature verification error: Bad GPG signature
#12 ERROR: process "/bin/sh -c dnf install -y -q     git &&     dnf clean all" did not complete successfully: exit code: 1

#11 [web 2/2] RUN dnf install -y -q     java-11-openjdk     git &&     dnf clean all
failed to solve: process "/bin/sh -c dnf install -y -q     git &&     dnf clean all" did not complete successfully: exit code: 1
#11 CANCELED
------
 > [omero 2/2] RUN dnf install -y -q     git &&     dnf clean all:
16.81  From       : /etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY-RHEL
19.45 Importing GPG key 0x08B40D20:
19.45  Userid     : "PostgreSQL RPM Repository <pgsql-pkg-yum@lists.postgresql.org>"
19.45  Fingerprint: D4BF 08AE 67A0 B4C7 A1DB CCD2 40BC A2B4 08B4 0D20
19.45  From       : /etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY-RHEL
21.81 Importing GPG key 0x08B40D20:
21.81  Userid     : "PostgreSQL RPM Repository <pgsql-pkg-yum@lists.postgresql.org>"
21.81  Fingerprint: D4BF 08AE 67A0 B4C7 A1DB CCD2 40BC A2B4 08B4 0D20
21.81  From       : /etc/pki/rpm-gpg/PGDG-RPM-GPG-KEY-RHEL
22.40 Error: Failed to download metadata for repo 'pgdg12': repomd.xml GPG signature verification error: Bad GPG signature
------
Warning: No resource found to remove for project "omeromapr".

@jburel
Copy link
Member

jburel commented Nov 21, 2024

Before doing a release, #92 should be considered since we now have email notification when pushing to Pypi

@jburel
Copy link
Member

jburel commented Nov 21, 2024

This PR should also be considered #91

@will-moore
Copy link
Member Author

#91 will already be included as it's merged. I just didn't list it in the changelog since it only affects test dependencies.

@jburel
Copy link
Member

jburel commented Nov 21, 2024

I know it is merged but I think it is helpful to have in the changelog. Changelog is not only for end user feature

@jburel
Copy link
Member

jburel commented Nov 21, 2024

you could even split it into

Features
Bugs
Others

@will-moore
Copy link
Member Author

@will-moore
Copy link
Member Author

@jburel Good to merge & release now?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
@will-moore
Copy link
Member Author

@jburel Thanks for the typo fix. Can I assume that it's otherwise good to merge now?

@dominikl
Copy link
Member

👍 Looks good to me.

@will-moore will-moore merged commit a535527 into ome:master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants