Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saeri training examples #6187

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Conversation

will-moore
Copy link
Member

Add examples from:
ome/omero-documentation#2010

NB: These code examples will now be run (checks that they don't throw errors), but this is not strictly the same as being tested.
E.g. we do not check that annotation = conn.getObject("Annotation", 1) returns anything.
But we have integration tests for that.

@will-moore will-moore changed the title Add saeri examples from docs PR saeri training examples Nov 27, 2019
@will-moore
Copy link
Member Author

will-moore commented Nov 28, 2019

https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-training/246/consoleFull is failing with

datasets = conn.getObjects("Dataset", [datasetId, datasetId+1])
01:20:39 TypeError: cannot concatenate 'str' and 'int' objects

Co-Authored-By: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
@will-moore
Copy link
Member Author

Training green again today https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-training/75/

@joshmoore joshmoore merged commit 54082ce into ome:develop Dec 5, 2019
@joshmoore joshmoore deleted the saeri_training_examples branch December 5, 2019 10:35
@jburel
Copy link
Member

jburel commented Dec 5, 2019

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants