Delete code associated with popularity endpoint

aiorobinhood/__init__.py

@@ -1,4 +1,4 @@
-__version__ = "1.0.0"
+__version__ = "2.0.0"
 __all__ = [
     "RobinhoodClient",
     # exceptions

aiorobinhood/client.py

@@ -640,53 +640,6 @@ async def get_instruments(
 
         return results
 
-    @check_tokens
-    @check_session
-    async def get_popularity(
-        self, ids: Iterable[str], pages: Optional[int] = None
-    ) -> List[Dict[str, Any]]:
-        """Fetch the popularity information pertaining to a list of securities.
-
-        Args:
-            ids: A sequence of instrument IDs.
-            pages: The number of pages to fetch (default is unlimited).
-
-        Returns:
-            Popularity data for each security, including number of open positions
-            held on Robinhood.
-
-        Raises:
-            ClientAPIError: Robinhood server responded with an error.
-            ClientRequestError: The HTTP request timed out or failed.
-            ClientUnauthenticatedError: The :class:`~.RobinhoodClient` is not logged in.
-            ClientUninitializedError: The :class:`~.RobinhoodClient` is not initialized.
-        """
-        assert self._session is not None
-
-        results = []
-        url = urls.POPULARITY.with_query({"ids": ",".join(ids)})
-
-        while url is not None and (pages is None or pages > 0):
-            try:
-                async with self._session.get(
-                    url,
-                    timeout=self._timeout,
-                    headers={"Authorization": self._access_token},
-                ) as resp:
-                    response = await resp.json()
-                    if resp.status != 200:
-                        raise ClientAPIError(
-                            resp.method, resp.url, resp.status, response
-                        )
-
-                    results += response["results"]
-                    url = response["next"]
-                    pages = pages and pages - 1
-            except (aiohttp.ClientError, asyncio.TimeoutError) as e:
-                raise ClientRequestError("GET", url) from e
-
-        return results
-
     @mutually_exclusive("symbols", "instruments")
     @check_tokens
     @check_session

aiorobinhood/urls.py

@@ -20,7 +20,6 @@
 # Stocks
 FUNDAMENTALS = BASE / "fundamentals/"
 INSTRUMENTS = BASE / "instruments/"
-POPULARITY = INSTRUMENTS / "popularity/"
 QUOTES = BASE / "quotes/"
 HISTORICALS = QUOTES / "historicals/"
 MIDLANDS = BASE / "midlands/"

docs/client.rst

@@ -40,7 +40,6 @@ Stocks
 
 .. automethod:: RobinhoodClient.get_fundamentals
 .. automethod:: RobinhoodClient.get_instruments
-.. automethod:: RobinhoodClient.get_popularity
 .. automethod:: RobinhoodClient.get_quotes
 .. automethod:: RobinhoodClient.get_historical_quotes
 .. automethod:: RobinhoodClient.get_tags

setup.py

@@ -37,6 +37,7 @@ def get_long_description() -> str:
         "Programming Language :: Python",
         "Programming Language :: Python :: 3",
         "Programming Language :: Python :: 3.7",
+        "Programming Language :: Python :: 3.8",
     ],
     license="MIT",
     keywords=["robinhood", "asyncio", "python3", "stocks"],

tests/test_stocks.py

@@ -13,7 +13,6 @@
     FUNDAMENTALS,
     HISTORICALS,
     INSTRUMENTS,
-    POPULARITY,
     QUOTES,
     RATINGS,
     TAGS,
@@ -152,69 +151,6 @@ async def test_get_instruments_value_error(logged_in_client):
         await client.get_instruments(symbol="ABCD", ids=["12345"])
 
 
-@pytest.mark.asyncio
-async def test_get_popularity(logged_in_client):
-    client, server = logged_in_client
-    task = asyncio.create_task(client.get_popularity(ids=["12345", "67890"]))
-
-    request = await server.receive_request(timeout=pytest.TIMEOUT)
-    assert request.method == "GET"
-    assert request.headers["Authorization"] == f"Bearer {pytest.ACCESS_TOKEN}"
-    assert request.path == POPULARITY.path
-    assert request.query["ids"] == "12345,67890"
-    server.send_response(
-        request,
-        content_type="application/json",
-        text=json.dumps({"next": str(pytest.NEXT), "results": [{"foo": "bar"}]}),
-    )
-
-    request = await server.receive_request(timeout=pytest.TIMEOUT)
-    assert request.method == "GET"
-    assert request.headers["Authorization"] == f"Bearer {pytest.ACCESS_TOKEN}"
-    assert request.path == pytest.NEXT.path
-    server.send_response(
-        request,
-        content_type="application/json",
-        text=json.dumps({"next": None, "results": [{"baz": "quux"}]}),
-    )
-
-    result = await asyncio.wait_for(task, pytest.TIMEOUT)
-    assert result == [{"foo": "bar"}, {"baz": "quux"}]
-
-
-@pytest.mark.asyncio
-async def test_get_popularity_api_error(logged_in_client):
-    client, server = logged_in_client
-    task = asyncio.create_task(client.get_popularity(ids=["12345"]))
-
-    request = await server.receive_request(timeout=pytest.TIMEOUT)
-    assert request.method == "GET"
-    assert request.headers["Authorization"] == f"Bearer {pytest.ACCESS_TOKEN}"
-    assert request.path == POPULARITY.path
-    assert request.query["ids"] == "12345"
-    server.send_response(request, status=400, content_type="application/json")
-
-    with pytest.raises(ClientAPIError):
-        await task
-
-
-@pytest.mark.asyncio
-async def test_get_popularity_timeout_error(logged_in_client):
-    client, server = logged_in_client
-    task = asyncio.create_task(client.get_popularity(ids=["12345"]))
-
-    request = await server.receive_request(timeout=pytest.TIMEOUT)
-    assert request.method == "GET"
-    assert request.headers["Authorization"] == f"Bearer {pytest.ACCESS_TOKEN}"
-    assert request.path == POPULARITY.path
-    assert request.query["ids"] == "12345"
-
-    with pytest.raises(ClientRequestError) as exc_info:
-        await asyncio.sleep(pytest.TIMEOUT + 1)
-        await task
-    assert isinstance(exc_info.value.__cause__, asyncio.TimeoutError)
-
-
 @pytest.mark.asyncio
 async def test_get_quotes(logged_in_client):
     client, server = logged_in_client