Added missing metadata to scheduled charge #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnasNaouchi Could you add unit tests to |
nuxzero
reviewed
Jul 12, 2023
| @@ -24,7 +26,7 @@ public void setup() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore("only hit the network when we need to.") | |||
| //@Ignore("only hit the network when we need to.") | |||
There was a problem hiding this comment.
Live tests supposed to be run on local only (at least for now).
There was a problem hiding this comment.
Yeah forgot to uncomment. Fixed now
Is It necessary at this stage as we need this before 19th ? |
|
Why not? |
@AnasNaouchi yes, please add unit tests |
nuxzero
approved these changes
Jul 12, 2023
danfowler
reviewed
Jul 12, 2023
AnasNaouchi
force-pushed
the
add_metadata_to_scheduled_charge
branch
from
9e78d8d
to
66d9c86
Compare
danfowler
reviewed
Jul 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
danfowler
approved these changes
Jul 14, 2023
aashishgurung
approved these changes
Jul 17, 2023
danfowler
reviewed
Jul 17, 2023
nuxzero
approved these changes
Jul 17, 2023
Co-authored-by: Daniel Fowler <daniel@opn.ooo>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metadata support for creating scheduled charges (Missing parameter).