Add code coverage and update Gradle #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
nuxzero
reviewed
Sep 8, 2023
| with: | ||
| distribution: 'temurin' | ||
| java-version: '11' | ||
| - run: chmod +x gradlew |
There was a problem hiding this comment.
I just wondering, is the gradlew file is already executable?
There was a problem hiding this comment.
Shall we just update the CI flow for the coverage report to avoid running the test twice?
Comment on lines
+1
to
+3
| sonar.projectKey=omise_omise-java | ||
| sonar.organization=omise | ||
| systemProp.sonar.host.url=https://sonarcloud.io |
There was a problem hiding this comment.
Do we need this file since these properties already define in here?
https://github.com/omise/omise-java/pull/154/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R158
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.