Skip to content

Commit

Permalink
Order ID sent in charge is replaced with order number
Browse files Browse the repository at this point in the history
  • Loading branch information
Aashish committed Mar 1, 2024
1 parent 326625d commit e9e3bf5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
5 changes: 3 additions & 2 deletions includes/gateway/abstract-omise-payment-base-card.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,14 @@ private function getOmiseCustomerId($user) {
private function prepareChargeData($order_id, $order, $omise_customer_id, $card_id, $token)
{
$currency = $order->get_currency();
$order_number = $order->get_order_number();
$data = [
'amount' => Omise_Money::to_subunit($order->get_total(), $currency),
'currency' => $currency,
'description' => 'WooCommerce Order id ' . $order_id,
'description' => 'WooCommerce Order id ' . $order_number,
'return_uri' => $this->get_redirect_url('omise_callback', $order_id, $order),
'metadata' => $this->get_metadata(
$order_id,
$order_number,
[ 'secure_form_enabled' => $this->getSecureFormState()]
),
];
Expand Down
11 changes: 6 additions & 5 deletions includes/gateway/traits/charge-request-builder-trait.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@ public function build_charge_request(
)
{
$currency = $order->get_currency();
$description = 'WooCommerce Order id ' . $order_id;
$order_number = $order->get_order_number();
$description = 'WooCommerce Order id ' . $order_number;

$request = [
'amount' => Omise_Money::to_subunit($order->get_total(), $currency),
'currency' => $currency,
'description' => $description,
'metadata' => $this->get_metadata($order_id),
'metadata' => $this->get_metadata($order_number),
'source' => [ 'type' => $source_type ]
];

Expand All @@ -40,13 +41,13 @@ public function build_charge_request(
}

/**
* @param string $order_id
* @param string $order_number
* @param array $additionalData
*/
public function get_metadata($order_id, $additionalData = [])
public function get_metadata($order_number, $additionalData = [])
{
// override order_id as a reference for webhook handlers.
$orderId = [ 'order_id' => $order_id ];
$orderId = [ 'order_id' => $order_number ];
return array_merge($orderId, $additionalData);
}

Expand Down

0 comments on commit e9e3bf5

Please sign in to comment.