refactor(*): cleanup #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
approved these changes
Jul 29, 2024
src/Greeter.sol
Outdated
Comment on lines
23
to
25
| bytes memory data = abi.encodeWithSelector(GreetingBook.greet.selector, msg.sender, greeting); | ||
|
|
||
| uint256 fee = xcall(omni.omniChainId(), greetingBook, data, DEST_TX_GAS_LIMIT); |
There was a problem hiding this comment.
If we bump sol versions, we can use abi,.encodeCall
test/GreetingBook.t.sol
Outdated
Comment on lines
25
to
34
| portal.mockXCall( | ||
| mockSourceChainId, | ||
| address(portal), | ||
| address(greetingBook), | ||
| abi.encodeWithSelector(GreetingBook.greet.selector, user, greeting), | ||
| gasLimit | ||
| ); | ||
| GreetingBook.Greeting memory lastGreet; | ||
| (lastGreet.user, lastGreet.message, lastGreet.sourceChainId, lastGreet.timestamp) = greetingBook.lastGreet(); | ||
| assertEq(lastGreet.message, greeting); |
There was a problem hiding this comment.
Thoughts on portal.mockXCall util?
There was a problem hiding this comment.
Only thing that's a little confusing is the sender field. We've set it to the portal here, but that doesn't really make sense, in fact is probably an anti-pattern
There was a problem hiding this comment.
This is the xmsg.sender - so it should never be the portal. We should change that here
ttarsi
added a commit
to omni-network/omni
that referenced
this pull request
Jul 30, 2024
the hello-world-template had a makeover ([here](omni-network/hello-world-template#8)) and references to it need to be updated. issue: #1596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script/bashdirectory, in favor of aMakefileRollupGreeterandGlobalGreetertoGreeterandGreetingBookGreetingBookxmsg.senderNote:
Currently the
make deploycommand is failing with:which is strange because building and testing works and
DeployGreetingBookhas nothing to do withIFeeOracle.