Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Fix import path in usage docs. #18

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix import path in usage docs. #18

merged 2 commits into from
Sep 11, 2023

Conversation

kevinhalliday
Copy link
Contributor

Addresses #17, though root issue (undesirable import path in hardhat projects) not resolved.

README.md Outdated Show resolved Hide resolved
ttarsi
ttarsi previously approved these changes Sep 11, 2023
- add explicit import examples for solidity for both npm and forge
  installations
- add import examples for js / tx
Copy link
Contributor

@ttarsi ttarsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevinhalliday kevinhalliday merged commit cb71b2d into main Sep 11, 2023
@kevinhalliday kevinhalliday deleted the update-usage-docs branch September 11, 2023 16:37
kevinhalliday added a commit that referenced this pull request Sep 14, 2023
Version 0.1.4 was published and released with outdated documentation.
Documentation was updated later in
#18.
This commit bumps the version number so that a new release can be
published with updated docs.

This also resolves discrepency between github and npm pacakage releases.
Npm has some 0.1.5-alpha.x pre relases that are not represented on github.
We should introduce some "npm publish on github release" flow so that
the two do not diverge like this in the future.
kevinhalliday added a commit that referenced this pull request Sep 14, 2023
Version 0.1.4 was published and released with outdated documentation.
Documentation was updated later in
#18.
This commit bumps the version number so that a new release can be
published with updated docs.

This also resolves discrepency between github and npm pacakage releases.
Npm has some 0.1.5-alpha.x pre relases that are not represented on github.
We should introduce some "npm publish on github release" flow so that
the two do not diverge like this in the future.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants