chore(cli/lib): revert to await on chain function use (#994)

Deprecate `CheckOnChain` and use noop logger for CLI call

task: none

cli/cmd/devnet.go

@@ -215,7 +215,7 @@ func loadDevnetNetwork(ctx context.Context) (netconf.Network, xchain.RPCEndpoint
 		return netconf.Network{}, nil, errors.Wrap(err, "make portal registry")
 	}
 
-	network, err := netconf.CheckOnChain(ctx, netID, portalReg, endpoints.Keys())
+	network, err := netconf.AwaitOnChain(log.WithNoopLogger(ctx), netID, portalReg, endpoints.Keys())
 	if err != nil {
 		return netconf.Network{}, nil, &cliError{
 			Msg:     "failed to check on-chain registry",

lib/netconf/provider.go

@@ -81,24 +81,6 @@ func AwaitOnChain(ctx context.Context, netID ID, portalRegistry *bindings.Portal
 	}
 }
 
-// CheckOnChain returns the network configuration if all expected chains are registered in the on-chain registry.
-// It returns an error if the context is canceled or if any of the expected chains are missing.
-func CheckOnChain(ctx context.Context, netID ID, portalRegistry *bindings.PortalRegistry, expected []string) (Network, error) {
-	portals, err := portalRegistry.List(&bind.CallOpts{Context: ctx})
-	if err != nil {
-		return Network{}, errors.Wrap(err, "failed fetching xchain registry from omni_evm")
-	}
-
-	network := networkFromPortals(netID, portals)
-	if !containsAll(network, expected) {
-		return Network{}, errors.New("xchain registry doesn't contain all expected chains")
-	}
-
-	log.Info(ctx, "XChain network configuration initialized from on-chain registry", "chains", network.ChainNamesByIDs())
-
-	return network, nil
-}
-
 // containsAll returns true if the network contains the all expected chains (by name or ID).
 func containsAll(network Network, expected []string) bool {
 	want := make(map[string]struct{}, len(expected))