ci(*): refactor to use workflow calls (#197)

Adds:
- `ci-main.yml`: runs specific jobs on merge to `main`
- `ci-pr.yml`: runs specific jobs on pr to `main`

If we like this setup, we can also:
- add a `ci-release.yml`, which would run on each release
- parameterize `goreleaser.yml`. on merge to `main`, we'd push the
`main` image, and on releases we'd push `latest`

task: none

---------

Co-authored-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>

.github/workflows/ci-main.yml

@@ -0,0 +1,26 @@
+name: ci main
+# continuous integration on push to main
+
+on:
+  push:
+    branches:
+      - main
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  pre-commit:
+    uses: ./.github/workflows/pre-commit.yml
+  go-tests:
+    uses: ./.github/workflows/gotest.yml
+  go-lint:
+    uses: ./.github/workflows/golangci-lint.yml
+  go-releaser:
+    uses: ./.github/workflows/goreleaser.yml
+    needs: [pre-commit, go-tests, go-lint]
+    secrets: inherit
+  e2e:
+    uses: ./.github/workflows/e2etest.yml
+    needs: [go-releaser]

.github/workflows/ci-pr.yml

@@ -0,0 +1,19 @@
+name: ci pr
+# continuous integration on pull requests to main
+
+on:
+  pull_request:
+    branches:
+      - main
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  pre-commit:
+    uses: ./.github/workflows/pre-commit.yml
+  go-tests:
+    uses: ./.github/workflows/gotest.yml
+  go-lint:
+    uses: ./.github/workflows/golangci-lint.yml

.github/workflows/e2etest.yml

@@ -1,11 +1,7 @@
 name: e2e tests
 
-# Run on main after building docker images
 on:
-  workflow_run:
-    workflows: ["go releaser"]
-    branches: [main]
-    types: [completed]
+  workflow_call:
 
 jobs:
   e2e_tests:

.github/workflows/golangci-lint.yml

@@ -1,16 +1,8 @@
 name: go lint
 # Run this separately from pre-commit since then we get nice inline messages in PRs.
 
-# Run on pull requests and commits to main
 on:
-  pull_request:
-  push:
-    branches:
-      - main
-
-permissions:
-  contents: read
-  pull-requests: read
+  workflow_call:
 
 jobs:
   golangci:
@@ -28,5 +20,3 @@ jobs:
           version: v1.55.2
           # Verbose with color. Just fail, don't fix issues. Use both annotations and normal output.
           args: -v --color=always --fix=false --out-format=colored-line-number,github-actions
-
-     # TODO(corver): Notify slack on failure on main

.github/workflows/goreleaser.yml

@@ -1,10 +1,7 @@
 name: go releaser
 
-# Run on all commits to main
 on:
-  push:
-    branches:
-      - main
+  workflow_call:
 
 # TODO(corver): Figure out which images to publish and how to do this via goreleaser.
 

.github/workflows/gotest.yml

@@ -1,12 +1,8 @@
 name: go tests
 # Run this separately from pre-commit for nice visual coverage.
 
-# Run on pull requests and commits to main
 on:
-  pull_request:
-  push:
-    branches:
-      - main
+  workflow_call:
 
 jobs:
   unit_tests:

.github/workflows/pre-commit.yml

@@ -1,11 +1,7 @@
 name: pre-commit hooks
 
-# Run on pull requests and commits to main
 on:
-  pull_request:
-  push:
-    branches:
-      - main
+  workflow_call:
 
 jobs:
   pre-commit: