feat(cli/docs): introduce devnet quickstart guide #1080
Conversation
|
Docs preview complete 🚀 see it here: https://omni-o7i2r5uac-omni-engineering.vercel.app |
idea404
changed the title
| omni_evm: 0x0DCd1Bf9A1b36cE34237eEaFef220932846BCD82 | ||
| mock_op: 0xa513E6E4b8f2a923D98304ec87F64353C4D5C853 | ||
| mock_arb: 0xa513E6E4b8f2a923D98304ec87F64353C4D5C853 |
There was a problem hiding this comment.
Maybe worth getting these to be same across each chain - what are we doing differently on omnievm
There was a problem hiding this comment.
At some point we could also show devs how to use our create3 factories here
There was a problem hiding this comment.
What would be the usecase?
There was a problem hiding this comment.
I'll use a different anvil key as the default, this is nonce+predeploy related
There was a problem hiding this comment.
Use case would be so devs can get consistent addrs across chain - using create3 would show them how they could
|
Docs preview complete 🚀 see it here: https://omni-eszlsupjo-omni-engineering.vercel.app |
|
Docs preview complete 🚀 see it here: https://omni-popio8ynj-omni-engineering.vercel.app |
|
Docs preview complete 🚀 see it here: https://omni-5eqizs0gh-omni-engineering.vercel.app |
|
Docs preview complete 🚀 see it here: https://omni-h0w11jrx4-omni-engineering.vercel.app |
cli/cmd/flags.go
Outdated
| @@ -24,6 +24,10 @@ func bindAVSAddress(cmd *cobra.Command, addr *string) { | |||
| cmd.Flags().StringVar(addr, "avs-address", *addr, "Optional address of the Omni AVS contract") | |||
| } | |||
|
|
|||
| func bindDeveloperForgeProjectConfig(cmd *cobra.Command, cfg *developerForgeProjectConfig) { | |||
| cmd.Flags().StringVar(&cfg.templateURL, "template", "https://github.com/omni-network/hello-world-template.git", "URL of the forge template to use") | |||
There was a problem hiding this comment.
This works - that way they can use any template they like. But we could also just use the name of it, and try to fetch https://github.com/omni-network/{template}.git
|
Docs preview complete 🚀 see it here: https://omni-nw2s5pzlq-omni-engineering.vercel.app |
cli/cmd/develop.go
Outdated
| @@ -70,3 +87,21 @@ func checkForgeInstalled() bool { | |||
|
|
|||
| return err == nil // If there is no error, forge is installed. | |||
| } | |||
|
|
|||
| // sanitizeInput validates and sanitizes the input to prevent command injection. | |||
| func sanitizeInput(input string) (string, error) { | |||
There was a problem hiding this comment.
Why do we need to do this? They're running this on their own machine.
Also if we are askibng for urls shouldnt' ths allow :
There was a problem hiding this comment.
true that was me fighting the pre-commit runner without questioning it
|
Docs preview complete 🚀 see it here: https://omni-kw3gy2n4o-omni-engineering.vercel.app |
bumps buildinfo version two versions higher as the there has been an intermediate release (static portal addresses for CLI) and current version includes new scaffolding functionality (seen in #1080) task: https://app.asana.com/0/1206208509925075/1207372351528365/f
Introduces scaffolding
hello-world-templateto CLI as default (and using--templateflag) and the quickstart page to the docstask: https://app.asana.com/0/1206208509925075/1207372351528365/f