chore(docker): add docker image tags #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
reviewed
Jan 24, 2024
|
@Lazar955 my expectation is that {{ .Tag }} is supposed to do that. We don't have tags in git yet, so I am not sure about that. |
pavelnikolov
changed the title
pavelnikolov
force-pushed
the
add-goreleaser-docker-image-tags
branch
from
301ff88
to
cf31b20
Compare
Create a dummy tag and check please. |
Signed-off-by: Pavel Nikolov <me@pavelnikolov.net>
pavelnikolov
force-pushed
the
add-goreleaser-docker-image-tags
branch
from
cf31b20
to
bbd9cc6
Compare
DanFlannel
pushed a commit
that referenced
this pull request
Jan 30, 2024
Add docker image tags in go-releaser config Before: <img width="684" alt="Screenshot 2024-01-24 at 17 24 16" src="https://github.com/omni-network/omni/assets/441740/433632cc-5258-4e27-b6d8-f05921af6fe9"> After: <img width="659" alt="Screenshot 2024-01-24 at 17 25 01" src="https://github.com/omni-network/omni/assets/441740/122b530c-2ca5-4ee9-bbc5-1270c9a269dc"> task: https://app.asana.com/0/1201980002255967/1206434523329322/f --------- Signed-off-by: Pavel Nikolov <me@pavelnikolov.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docker image tags in go-releaser config
Before:
After:
task: https://app.asana.com/0/1201980002255967/1206434523329322/f