feat(e2e): add staking admin commands #1815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
requested review from
corverroos,
arajasek,
brid and
ttarsi
as code owners
kevinhalliday
force-pushed
the
kh/staking-admin
branch
from
4b875ee
to
7a7c91e
Compare
kevinhalliday
commented
Sep 4, 2024
Comment on lines
+77
to
+80
| if !ok { | ||
| log.Info(ctx, "No static staking config, skipping", "network", s.network.ID) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Right now just logging and returning nil. Though we can configure these for devnet / staging & use them in our e2e flow. Right now just do it off of genesis alloc accounts.
Another thing I need to add is how to tests - devnet will just deploy what's in binary. And this command uses what's in binary. So need to add an override for tests.
kevinhalliday
commented
Sep 4, 2024
| } | ||
|
|
||
| emit AllowlistSet(validators); | ||
| } |
There was a problem hiding this comment.
Changes here amount to:
- replace
disableAllowlist / enableAllowlistwithsetAllowlistEnabled - replace
allowValidators / disallowValidatorswithsetAllowlist
Add Staking.sol admin commands. - rewrite Staking.sol to allow for idompentent config managment - add upgrade script, so that we can upgrade Staking.sol on Omega - add idompentent configure script - add e2e cmd to test all admin commands Additional: - namespace admin commands by contract type - refactor all admin commands, with less restrictive abstractions - move admin command code to e2e/app root
kevinhalliday
force-pushed
the
kh/staking-admin
branch
from
7a7c91e
to
de62e92
Compare
|
Closing for #1823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Staking.sol admin commands.
Additional:
issue: #1814