Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer/graphql): reading from db #190

Merged
merged 8 commits into from
Jan 30, 2024
Merged

feat(explorer/graphql): reading from db #190

merged 8 commits into from
Jan 30, 2024

Conversation

DanFlannel
Copy link
Contributor

Hooking graphql into db as well as adding local endpoint without db for testing

task: none

@DanFlannel DanFlannel changed the base branch from main to indexer-mock-inserts January 26, 2024 17:22
@DanFlannel
Copy link
Contributor Author

PR 4 in stack

@DanFlannel DanFlannel requested a review from a team January 26, 2024 17:51
@DanFlannel DanFlannel marked this pull request as ready for review January 26, 2024 17:51
jmozah
jmozah reviewed Jan 29, 2024
View reviewed changes
explorer/graphql/cmd/cmd.go Outdated Show resolved Hide resolved
jmozah
jmozah reviewed Jan 29, 2024
View reviewed changes
explorer/graphql/app/app.go Outdated Show resolved Hide resolved
@DanFlannel
Copy link
Contributor Author

@jmozah
created follow up tasks:
https://app.asana.com/0/1206208509925075/1206472143273948
https://app.asana.com/0/1206208509925075/1206472143273951

@DanFlannel DanFlannel changed the title feat(explorer/graphql): reading from db and local testing feat(explorer/graphql): reading from db Jan 30, 2024
Base automatically changed from indexer-mock-inserts to main January 30, 2024 17:54
@DanFlannel DanFlannel merged commit 88daf44 into main Jan 30, 2024
4 checks passed
@DanFlannel DanFlannel deleted the graphql-reading-from-db branch January 30, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmozah jmozah jmozah left review comments

@kevinhalliday kevinhalliday kevinhalliday approved these changes

@pavelnikolov pavelnikolov Awaiting requested review from pavelnikolov

@Lazar955 Lazar955 Awaiting requested review from Lazar955

@ttarsi ttarsi Awaiting requested review from ttarsi

@corverroos corverroos Awaiting requested review from corverroos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanFlannel @jmozah @kevinhalliday