Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): verify xsubmission merke proofs #199

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

kevinhalliday
Copy link
Contributor

Verify XSubmission merkle proofs on xsubmit.

task: https://app.asana.com/0/1206208509925075/1206424499013448

@kevinhalliday
Copy link
Contributor Author

One sec I didn't actually add verification

Copy link
Contributor

@ttarsi ttarsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple q's

contracts/src/libraries/XBlockMerkleProof.sol Outdated Show resolved Hide resolved
contracts/src/libraries/XBlockMerkleProof.sol Outdated Show resolved Hide resolved
contracts/test/common/Fixtures.sol Outdated Show resolved Hide resolved
contracts/test/common/Fixtures.sol Show resolved Hide resolved
contracts/test/common/TestPortal.sol Outdated Show resolved Hide resolved
contracts/test/common/Utils.sol Show resolved Hide resolved
@kevinhalliday kevinhalliday merged commit bbc2e7c into main Jan 30, 2024
4 checks passed
@kevinhalliday kevinhalliday deleted the kh/xsubmit-verify-proofs branch January 30, 2024 00:55
DanFlannel pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants