refactor(proto): non-nullable proto arrays #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Oct 10, 2024
| @@ -5,12 +5,12 @@ | |||
| "Msgs": [ | |||
| { | |||
| "SourceChainID": 77, | |||
| "DestChainID": 1894687307556873581, | |||
There was a problem hiding this comment.
this change is just due to fuzzing that follows a different path and doesn't break things on the wire.
sideninja
reviewed
Oct 10, 2024
| @@ -25,7 +26,7 @@ message MsgExecutionPayload { | |||
| option (cosmos.msg.v1.signer) = "authority"; | |||
| string authority = 1; | |||
| bytes execution_payload = 2; | |||
| repeated EVMEvent prev_payload_events = 3; | |||
| repeated EVMEvent prev_payload_events = 3 [(gogoproto.nullable) = false]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors all cosmos module query protos array fields to be non-nullable. This changes the generated types from pointers to non-points. This avoid the need for nil checks.
Nice thing is that the wire serialization remain identical, only runtime types are different, which means this is backwards compatible!
issue: none