Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(halo): ready command integrated into docker containers #2179

Merged
merged 5 commits into from
Oct 17, 2024
Merged

feat(halo): ready command integrated into docker containers #2179

merged 5 commits into from
Oct 17, 2024

Conversation

chmllr
Copy link
Contributor

@chmllr chmllr commented Oct 15, 2024 •
edited
Loading

  • Adds a new halo command ready indicating the readiness of the halo node.
  • Integrates the new command into the halo and halovisor images.
  • Implements a new prometheus metrics exposing the readiness status

issue: #2091

corverroos
corverroos reviewed Oct 16, 2024
View reviewed changes
halo/healthcheck.sh Outdated Show resolved Hide resolved
halo/healthcheck.sh Outdated Show resolved Hide resolved
halo/healthcheck.sh Outdated Show resolved Hide resolved
@chmllr chmllr force-pushed the chmllr/ready-endpoint-integration branch from 14a4111 to 8f6c979 Compare October 16, 2024 17:31
corverroos
corverroos reviewed Oct 16, 2024
View reviewed changes
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
@chmllr chmllr changed the title DRAFT feat(halo): ready command integrated into docker containers Oct 17, 2024
@chmllr chmllr force-pushed the chmllr/ready-endpoint-integration branch from f9d0042 to 3bac687 Compare October 17, 2024 10:53
@chmllr chmllr marked this pull request as ready for review October 17, 2024 11:01
corverroos
corverroos approved these changes Oct 17, 2024
View reviewed changes
halo/Dockerfile Outdated Show resolved Hide resolved
halo/app/monitor.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/cmd/ready.go Show resolved Hide resolved
halo/cmd/ready.go Outdated Show resolved Hide resolved
halo/app/monitor.go Outdated Show resolved Hide resolved
halo/app/metrics.go Outdated Show resolved Hide resolved
@chmllr chmllr force-pushed the chmllr/ready-endpoint-integration branch from 0e1b803 to fe28693 Compare October 17, 2024 14:14
@chmllr chmllr merged commit ac86ae7 into main Oct 17, 2024
18 checks passed
@chmllr chmllr deleted the chmllr/ready-endpoint-integration branch October 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corverroos corverroos corverroos approved these changes

@sideninja sideninja Awaiting requested review from sideninja sideninja is a code owner

@kc1116 kc1116 Awaiting requested review from kc1116 kc1116 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chmllr @corverroos