feat(relayer): add pnl logs for xsubmissions #2197
Merged
+359
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
requested review from
corverroos,
sideninja,
chmllr and
kc1116
as code owners
kevinhalliday
force-pushed
the
kh/relayer-pnl
branch
9 times, most recently
from
593924b
to
8af870a
Compare
corverroos
approved these changes
Oct 17, 2024
relayer/app/pnl.go
Outdated
|
|
||
| var fees amts | ||
|
|
||
| // do not calculate fees for cchain submissions - we do not collect them |
There was a problem hiding this comment.
we should do accounting for everything
kevinhalliday
force-pushed
the
kh/relayer-pnl
branch
from
8af870a
to
964891b
Compare
sideninja
reviewed
Oct 17, 2024
sideninja
reviewed
Oct 17, 2024
sideninja
approved these changes
Oct 17, 2024
kevinhalliday
force-pushed
the
kh/relayer-pnl
branch
from
964891b
to
13bcc9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add profit-and-loss logs for xsubmissions.
We can sum on these metrics to in grafana to measure pnl.
issue: #1962