ci(github): adds go actions #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
requested changes
Jan 5, 2024
.github/workflows/go.yml
Outdated
| name: Test | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
not sure testing twice is required, it doubles the time it take. Why do we need to test in multiple architectures?
There was a problem hiding this comment.
should we not see if it runs in atleast 2 of the most important archs?
.github/workflows/go.yml
Outdated
| cache: true | ||
| go-version-file: go.mod | ||
| - name: Build | ||
| run: make build |
.github/workflows/go.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Set up Go | ||
| uses: actions/setup-go@v4 |
There was a problem hiding this comment.
Lets use latest version of these actions, ie:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
.github/workflows/go.yml
Outdated
Comment on lines
23
to
25
| go get -v -t -d ./... | ||
| - name: Build | ||
| run: go build -v ./... |
There was a problem hiding this comment.
what is the purpose of building all binaries? It doesn't seem like the build artefacts are cached? golangci-lint already detects is code doesn't compile.
.github/workflows/go.yml
Outdated
| with: | ||
| skip-cache: false | ||
| version: v1.55.2 | ||
| args: --config=.golangci.yml --out-${NO_FUTURE}format colored-line-number |
There was a problem hiding this comment.
suggest:
# Verbose with color. Just fail, don't fix issues. Use both annotations and normal output.
args: -v --color=always --fix=false --out-format=colored-line-number,github-actions
No need to specify --config=.golangci.yml as that is the defailt
What is the purpose of NO_FUTURE?
This PR adds the github standard "Contributor Covenant Code of Conduct". task: none
Adds a simple `Makefile` to the root that install the linter (`pre-commit`) and does linting. To see available make commands, run `make help`. task: none
Adds two github actions: - `golangci-lint`: Runs the go linter so issues are added inline to PR. - `pre-commit`: Runs pre-commit hooks (excluding golangci-lint) task: none
Adds the basic xtypes. Note these are Golang optimised types. They do not represent the solidity types, nor how these types are serialised exactly, since solidity is data sensitive and should remove all duplication. These types are slightly denormalised, containing `XMsgID` which contain `XStreamID` which is a slight duplication since `SourceChainID` can usually be inferred from the context. This is included for convenience and for explicitness. task: https://app.asana.com/0/1206208509925075/1206208573439595
Implement basic app cmd pattern with re-useable code in `lib/cmd`. task: none
Adds goreleaser config and building halo binary and docker images. Also adds simple release action that pushes the latest docker image to dockerhub. task: none
|
A previous PR took care of lint which does most of the stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add go actions like build, format, lint and gosec to the workflows.
task: none