feat(contracts): make portal xmsg params configurable #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs preview complete 🚀 see it here: https://omni-873qgekxx-omni-engineering.vercel.app |
ttarsi
approved these changes
Apr 23, 2024
ttarsi
reviewed
Apr 23, 2024
kevinhalliday
force-pushed
the
kh/configurable-params
branch
from
e905e9f
to
ad27e3a
Compare
kevinhalliday
requested review from
corverroos,
Lazar955,
DanFlannel and
pavelnikolov
as code owners
kevinhalliday
force-pushed
the
kh/configurable-params
branch
from
ad27e3a
to
ac94aa6
Compare
|
Docs preview complete 🚀 see it here: https://omni-na327wktu-omni-engineering.vercel.app |
|
Docs preview complete 🚀 see it here: https://omni-iwe8t0uy0-omni-engineering.vercel.app |
kevinhalliday
force-pushed
the
kh/configurable-params
branch
from
ac94aa6
to
5e35265
Compare
|
Docs preview complete 🚀 see it here: https://omni-pra0q5ass-omni-engineering.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make portal xmsg params admin controlled, rather than constants.
Additional:
task: https://app.asana.com/0/1206208509925075/1207144685868128