Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional error on page reload for an already connected wallet #293

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

ufe-pr
Copy link
Collaborator

@ufe-pr ufe-pr commented Jan 6, 2025

Fixes #292

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lasereyes-mono-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:04am

@ufe-pr ufe-pr changed the title Fix occasional error on page reload for an already connected wallet (#292) Fix occasional error on page reload for an already connected wallet Jan 6, 2025
@hathbanger
Copy link
Contributor

yo @ufe-pr imma close this, wanna reopen against dev?

the flow goes:
pull dev
branch off dev
make changes
push
open pr against dev
merge
open pr dev against main
merge (triggers auto publish)

@hathbanger hathbanger closed this Jan 7, 2025
@hathbanger hathbanger reopened this Jan 7, 2025
@hathbanger hathbanger changed the base branch from main to dev January 7, 2025 12:00
@hathbanger hathbanger merged commit 562d9f1 into dev Jan 7, 2025
6 of 7 checks passed
@hathbanger hathbanger deleted the bug/race-condition branch January 7, 2025 13:13
@hathbanger hathbanger mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The library occasionally errors when reloading the page to an app that had been already connected prior
2 participants