fix for create instance in network type fields condition show or not show

[mohandholu43]

Summary by CodeRabbit

• New Features

  • Enhanced service configuration logic to handle multi-tenancy scenarios
  • Updated resource instance form to support dynamic network type field visibility based on service configuration

• Bug Fixes

  • Improved handling of network type settings for different service product tiers

[coderabbitai]

Walkthrough

The changes introduce a new computed property isMultiTenancy in the service page to determine the multi-tenancy configuration of a service. This property is used to modify the logic for handling network types during resource instance creation. The modifications affect how network type fields are conditionally rendered in the CreateResourceInstanceForm component, specifically adjusting the visibility based on the multi-tenancy status of the service.

Changes

File	Change Summary
pages/access/service/[serviceId].js	Added isMultiTenancy computed property to check if service product tier is OMNISTRATE_MULTI_TENANCY
src/components/Forms/CreateResourceInstanceForm.jsx	Added isMultiTenancy prop to modify network type field rendering conditions

Sequence Diagram

sequenceDiagram
    participant Service Page
    participant CreateResourceInstanceForm
    
    Service Page->>CreateResourceInstanceForm: Pass isMultiTenancy prop
    CreateResourceInstanceForm->>CreateResourceInstanceForm: Evaluate networkTypeFieldExists
    CreateResourceInstanceForm-->>User: Render network type field conditionally

Loading

The sequence diagram illustrates how the isMultiTenancy prop is passed from the service page to the create resource instance form, influencing the conditional rendering of the network type field based on the service's multi-tenancy configuration.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b10c1e4 and 5cd253a.

📒 Files selected for processing (2)

• pages/access/service/[serviceId].js (3 hunks)
• src/components/Forms/CreateResourceInstanceForm.jsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: package

🔇 Additional comments (5)

src/components/Forms/CreateResourceInstanceForm.jsx (2)

68-68: LGTM! New prop added for multi-tenancy configuration.

The isMultiTenancy prop is correctly added to the component's props destructuring.

---

238-238: LGTM! Network type field visibility now considers multi-tenancy status.

The condition for networkTypeFieldExists is correctly updated to hide the network type field when the service is configured for multi-tenancy.

pages/access/service/[serviceId].js (3)

282-287: LGTM! Efficient memoization of multi-tenancy status.

The isMultiTenancy variable is correctly memoized using useMemo and depends on the service's product tier type.

---

948-952: LGTM! Network type deletion logic updated for multi-tenancy.

The condition for deleting the network type from the form data is correctly updated to handle multi-tenancy services.

---

2038-2038: LGTM! Multi-tenancy prop correctly passed to form component.

The isMultiTenancy prop is properly passed to the CreateResourceInstanceForm component.

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.