Skip to content

use window virtualizer when rendering forum posts #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshxfi merged 3 commits into from
Aug 25, 2025
Merged

use window virtualizer when rendering forum posts #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40f4d85
fix: use window virtualizer instead
joshxfi Aug 25, 2025
351503c
chore: update deps
joshxfi Aug 25, 2025
81390ff
fix: adjust min height on submit page
joshxfi Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forum/components/forum-navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type Props = {

export function ForumNavbar({ forumId, renderButtons }: Props) {
return (
<nav className="flex justify-between items-center w-full max-w-xl mx-auto py-6 fixed top-0 left-0 right-0 bg-background container">
<nav className="flex justify-between items-center w-full max-w-xl mx-auto py-6 fixed top-0 left-0 right-0 bg-background container z-50">
<div className="flex items-center gap-2">
<Link href="/forum" className="font-bold tracking-tighter">
um<i>edu</i>
Expand Down
11 changes: 5 additions & 6 deletions app/forum/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* eslint-disable react-hooks/exhaustive-deps */
"use client";

import { useEffect, useRef } from "react";
import { useVirtualizer } from "@tanstack/react-virtual";
import { useEffect } from "react";
import { useWindowVirtualizer } from "@tanstack/react-virtual";
import { useInfiniteQuery } from "@tanstack/react-query";
import { AlertCircleIcon, MessageCircleDashedIcon } from "lucide-react";
import { useThrottledCallback } from "@tanstack/react-pacer/throttler";
Expand Down Expand Up @@ -43,13 +43,12 @@ export default function FeedPage() {
});

const allPosts = data?.pages.flatMap((page) => page.posts) ?? [];
const parentRef = useRef<HTMLDivElement>(null);

const virtualizer = useVirtualizer({
const virtualizer = useWindowVirtualizer({
count: hasNextPage ? allPosts.length + 1 : allPosts.length,
getScrollElement: () => parentRef.current,
estimateSize: () => 200,
paddingEnd: 100,
overscan: 6,
});

const handleNextPage = useThrottledCallback(
Expand Down Expand Up @@ -110,7 +109,7 @@ export default function FeedPage() {
}

return (
<div ref={parentRef} className="h-[700px] w-full overflow-auto">
<div className="w-full overflow-auto">
{allPosts.length === 0 && !isFetching && (
<Alert>
<MessageCircleDashedIcon />
Expand Down
2 changes: 1 addition & 1 deletion app/forum/submit/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default function SubmitPage() {

return (
<form
className="space-y-6 w-full"
className="space-y-6 w-full min-h-screen"
onSubmit={(e) => {
e.preventDefault();
form.handleSubmit();
Expand Down
Loading