John Kay's Pull Request#3
Open
stackedactors1 wants to merge 8 commits intoone-on-one:masterfrom
stackedactors1:master
Open
John Kay's Pull Request#3stackedactors1 wants to merge 8 commits intoone-on-one:masterfrom stackedactors1:master
stackedactors1 wants to merge 8 commits intoone-on-one:masterfrom
stackedactors1:master
Conversation
added 7 commits
January 21, 2014 23:04
index.html - added meta tag in header for mobile development, added jQuery and custom js file in js folder, referenced those before </body> for faster load time. script.js - made ajax call to http://fedtest.aws.af.cm to populate radio buttons. main.css - added min height to education_level div to prevent jumping when the ajax call is made to populate radio buttons.
…ting the form with errors. script.js - built custom submit function for form validation. Also made error handling obj for functions to check certain input fields. main.css - added .clear class, its always good to have a class setup for clearing. Formatted radio button layout. side note: I know adding jQuery may have been too much to add on something this small but I thought the slide effect on the form submission with errors is really cool!
… thought adding this would make it more clear on the way of typing it in. main.css - stylized the phone number format description.
Contributor
|
I will take a look at it and get back to you if I have any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To whom it may concern, I am pretty sure my test is complete. Please take a look at the files and tell me what you think or anything I may have missed.
Thank You.