[Bindless][Exp] Add device queries for sampled image fetch #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related DPC++ MR: intel/llvm#12447 |
Seanst98
approved these changes
Jan 19, 2024
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
aa442a3 to
9713f7d
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
- Coverage 14.82% 12.46% -2.36%
==========================================
Files 250 239 -11
Lines 36220 36087 -133
Branches 4094 4092 -2
==========================================
- Hits 5369 4498 -871
- Misses 30800 31585 +785
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
isaacault
approved these changes
Jan 22, 2024
fabiomestre
reviewed
Jan 22, 2024
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
9713f7d to
c9f5374
Compare
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
2 times, most recently
from
6ddda43 to
098b310
Compare
fabiomestre
approved these changes
Feb 6, 2024
|
Friendly ping @oneapi-src/unified-runtime-cuda-write |
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
2 times, most recently
from
81d9401 to
18f3039
Compare
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
3 times, most recently
from
b386db5 to
0f07c69
Compare
|
Friendly ping to @oneapi-src/unified-runtime-cuda-write and @ldrumm for re-reviews/approvals/merging. The changes in this MR are minimal, however I would need them to be merged before I can update the related DPC++ MR to make it ready to review and get it closer to merging. Note that the related DPC++ MR fails CI but this is stemming from tests that are unrelated to that particular MR/ |
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
0f07c69 to
7500178
Compare
DBDuncan
approved these changes
Mar 1, 2024
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
2 times, most recently
from
803036e to
30e4fd3
Compare
|
Marked as ready to merge. Corresponding DPC++ PR has gotten approvals and passed the last CI (currently running again due to git merge, but it is passing). |
kbenzie
added
specification
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
8 times, most recently
from
8fe880b to
60b8afe
Compare
github-actions
bot
added
the
experimental
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
2 times, most recently
from
69e70cb to
0ead0ca
Compare
Added the following queries for device capabilities of fetching sampled images: - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_USM_EXP - DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_EXP
przemektmalon
force-pushed
the
przemek/sampled-image-fetch
branch
from
0ead0ca to
21f023f
Compare
aarongreig
added a commit
to aarongreig/unified-runtime
that referenced
this pull request
Apr 17, 2024
Merged
aarongreig
added a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following queries for device capabilities of fetching sampled images: