Skip to content

[L0] Fix Native Host memory usage on device with copy back sync #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nrspruit
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.49%. Comparing base (78ef1ca) to head (a00865d).
Report is 146 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
- Coverage   14.82%   12.49%   -2.33%     
==========================================
  Files         250      239      -11     
  Lines       36220    36003     -217     
  Branches     4094     4086       -8     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31501     +701     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrspruit nrspruit added level-zero L0 adapter specific issues v0.9.x Include in the v0.9.x release labels Mar 13, 2024
@nrspruit nrspruit force-pushed the fix_device_native_proxy_buffer branch from 83720ba to df03d2b Compare March 14, 2024 14:38
@nrspruit nrspruit force-pushed the fix_device_native_proxy_buffer branch from df03d2b to a00865d Compare March 14, 2024 15:23
nrspruit added a commit to nrspruit/llvm that referenced this pull request Mar 14, 2024
pre-commit PR for oneapi-src/unified-runtime#1439

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Mar 14, 2024
Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
@kbenzie kbenzie force-pushed the fix_device_native_proxy_buffer branch from a00865d to 9b3cf9d Compare March 20, 2024 10:39
@kbenzie kbenzie merged commit c98fdbc into oneapi-src:main Mar 21, 2024
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Mar 21, 2024
…13014)

pre-commit PR for
oneapi-src/unified-runtime#1439

---------

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
@againull
Copy link
Contributor

Uplifting intel/llvm to this commit:
intel/llvm#13014

Caused this failure:

Timed Out Tests (1):
SYCL :: Plugin/interop-level-zero-buffer.cpp

on Arc post-commit.
Link to post-commit: https://github.com/intel/llvm/actions/runs/8376090160/job/22935485187

I reverted the change in intel/llvm intel/llvm#13102, but it was committed again with intel/llvm#13033

Please revert this commit until regression is fixed.

@nrspruit
Copy link
Contributor Author

Uplifting intel/llvm to this commit: intel/llvm#13014

Caused this failure:

Timed Out Tests (1): SYCL :: Plugin/interop-level-zero-buffer.cpp

on Arc post-commit. Link to post-commit: https://github.com/intel/llvm/actions/runs/8376090160/job/22935485187

I reverted the change in intel/llvm intel/llvm#13102, but it was committed again with intel/llvm#13033

Please revert this commit until regression is fixed.

Hello @againull ,

What changed when the tests passed in the pre-commit CI for this change?

If those tests were not run by the infra for "interop" changes, then there seems to be a problem with the CI choosing the tests to run.

kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Apr 16, 2024
…ntel#13014)

pre-commit PR for
oneapi-src/unified-runtime#1439

---------

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.9.x Include in the v0.9.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants