Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to align CTS and Spec for Device #2597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improvements to align CTS and Spec for Device #2597

wants to merge 1 commit into from
+3,604 −883

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Jan 22, 2025 •
edited
Loading

  • Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case - Restructure GetInfo CTS tests to use separate tests instead of a switch #2290
  • Remove the UR/OpenCL Device enum map function - no point maintaining both a switch case and a separate mapping function
  • Update some spec wording for consistency
  • Add missing Device info enums to OpenCL adapater
  • Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
  • Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h
  • Update spec to say info queries that return char[] are null-terminated
  • Add missing unsupported device enums to HIP adapter
  • Reverted bindless image types back to size_t
  • Moved ComponentDevices test to a separate PlatformTest derived fixture
  • Added new ASSERT_QUERY_RETURNS_VALUE macro as a helper to validate simple numerical GetInfo queries
  • Added new stringPropertyIsValid helper function to validate string queries
  • Add missing unsupported device enums to HIP adapter

intel/llvm#16746

@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. images UR images specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Jan 22, 2025
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch 4 times, most recently from 37c3c32 to b8a9271 Compare January 23, 2025 10:29
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 23, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
d914426 
…neapi-src/unified-runtime#2597
@martygrant martygrant mentioned this pull request Jan 23, 2025
Open
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch 3 times, most recently from 2cab273 to 1ce6d4e Compare January 23, 2025 16:17
@martygrant martygrant mentioned this pull request Jan 24, 2025
Closed
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 24, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
73d6fd0 
…neapi-src/unified-runtime#2597
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 1ce6d4e to 56bec8d Compare January 24, 2025 16:14
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 24, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
09eac51 
…neapi-src/unified-runtime#2597
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 56bec8d to e153d00 Compare January 24, 2025 16:55
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 24, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
09ddfe9 
…neapi-src/unified-runtime#2597
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch 2 times, most recently from caa66b2 to 7d961b4 Compare January 27, 2025 11:05
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 27, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
2c8710b 
…neapi-src/unified-runtime#2597
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 7d961b4 to b12864d Compare January 27, 2025 11:49
martygrant added a commit to martygrant/llvm that referenced this pull request Jan 27, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
3b88cac 
…neapi-src/unified-runtime#2597
@martygrant martygrant requested a review from a team as a code owner January 27, 2025 14:54
@martygrant martygrant requested a review from npmiller January 27, 2025 14:54
@martygrant martygrant mentioned this pull request Jan 27, 2025
Open
14 tasks
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from b12864d to 637c7f9 Compare January 29, 2025 11:32
aarongreig
aarongreig reviewed Jan 29, 2025
View reviewed changes
test/conformance/device/urDeviceGetInfo.cpp Outdated Show resolved Hide resolved
test/conformance/device/urDeviceGetInfo.cpp Outdated Show resolved Hide resolved
test/conformance/device/urDeviceGetInfo.cpp Outdated Show resolved Hide resolved
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 637c7f9 to 0ff7ae2 Compare January 31, 2025 10:59
martygrant added a commit to martygrant/unified-runtime that referenced this pull request Jan 31, 2025
@martygrant
Reorganised urEventGetProfilingInfo test into separate tests instead …
f2be414 
…of a switch and rework various urXGetInfo tests:

- Housekeeping pass to tidy up tests, renaming and adding consts where appropriate
- Added ASSERT_INFO_CALL and uur::stringPropertyIsValid helpers from oneapi-src#2597
- Used above helpers across all tests to better validate numerical and char[] queries, and reworked some char[] queries
- Removed any non useful checks on vector sizes after passing them into a urXGetInfo query
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch 2 times, most recently from 9475d01 to d626a1a Compare February 3, 2025 12:21
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from d626a1a to a9d9aa3 Compare February 3, 2025 16:41
martygrant added a commit to martygrant/unified-runtime that referenced this pull request Feb 3, 2025
@martygrant
Reorganised urEventGetProfilingInfo test into separate tests instead …
a2f7b34 
…of a switch and rework various urXGetInfo tests:

- Housekeeping pass to tidy up tests, renaming and adding consts where appropriate
- Added ASSERT_QUERY_RETURNS_VALUE and uur::stringPropertyIsValid helpers from oneapi-src#2597
- Used above helpers across all tests to better validate numerical and char[] queries, and reworked some char[] queries
- Removed any non useful checks on vector sizes after passing them into a urXGetInfo query
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from a9d9aa3 to 25f9af4 Compare February 3, 2025 17:41
martygrant added a commit to martygrant/llvm that referenced this pull request Feb 3, 2025
@martygrant
[UR] Update tag for Improvements to align CTS and Spec for Device - o…
c5c7e20 
…neapi-src/unified-runtime#2597
@martygrant
Copy link
Contributor Author

@oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write @oneapi-src/unified-runtime-level-zero-write @oneapi-src/unified-runtime-native-cpu-write friendly bump for a review please, the adapter changes are very minor

martygrant added a commit to martygrant/unified-runtime that referenced this pull request Feb 5, 2025
@martygrant
Reorganised urEventGetProfilingInfo test into separate tests instead …
a58da89 
…of a switch and rework various urXGetInfo tests:

- Housekeeping pass to tidy up tests, renaming and adding consts where appropriate
- Added ASSERT_QUERY_RETURNS_VALUE and uur::stringPropertyIsValid helpers from oneapi-src#2597
- Used above helpers across all tests to better validate numerical and char[] queries, and reworked some char[] queries
- Removed any non useful checks on vector sizes after passing them into a urXGetInfo query
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 25f9af4 to db3ae98 Compare February 5, 2025 16:08
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from db3ae98 to 2c13096 Compare February 5, 2025 16:22
@martygrant
Improvements to align CTS and Spec for Device:
16d5edc 
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case - oneapi-src#2290
- Remove the UR/OpenCL Device enum map function - no point maintaining both a switch case and a separate mapping function
- Update some spec wording for consistency
- Add missing Device info enums to OpenCL adapater
- Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE
- Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h
- Update spec to say info queries that return char[] are null-terminated
- Add missing unsupported device enums to HIP adapter
- Reverted bindless image types back to size_t
- Moved ComponentDevices test to a separate PlatformTest derived fixture
- Added new ASSERT_QUERY_RETURNS_VALUE macro as a helper to validate simple numerical GetInfo queries
- Added new stringPropertyIsValid helper function to validate string queries
@martygrant martygrant force-pushed the martin/device-cts-spec-gap-redo branch from 2c13096 to 16d5edc Compare February 5, 2025 16:39
martygrant added a commit to martygrant/unified-runtime that referenced this pull request Feb 5, 2025
@martygrant
Reorganised urEventGetProfilingInfo test into separate tests instead …
b52be5b 
…of a switch and rework various urXGetInfo tests:

- Housekeeping pass to tidy up tests, renaming and adding consts where appropriate
- Added ASSERT_QUERY_RETURNS_VALUE and uur::stringPropertyIsValid helpers from oneapi-src#2597
- Used above helpers across all tests to better validate numerical and char[] queries, and reworked some char[] queries
- Removed any non useful checks on vector sizes after passing them into a urXGetInfo query
@coldav
Copy link
Contributor

coldav commented Feb 5, 2025

LGTM native cpu

@martygrant martygrant added the ready to merge Added to PR's which are ready to merge label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldav coldav coldav approved these changes

@przemektmalon przemektmalon przemektmalon approved these changes

@aarongreig aarongreig aarongreig approved these changes

@pbalcer pbalcer pbalcer approved these changes

@frasercrmck frasercrmck frasercrmck approved these changes

@npmiller npmiller Awaiting requested review from npmiller npmiller is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues images UR images level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martygrant @coldav @frasercrmck @pbalcer @aarongreig @przemektmalon