added filename and line number to logs

[lslusarczyk]

Added an option to print line number and filename in log file. When fileline:1 is specified in an environment variable describing log, e.g:

UR_LOG_LEVEL_ZERO="level:debug;flush:warning;fileline:1;output:file,juju-l0.log"

then instead of seeing logs like this

<LEVEL_ZERO>[DEBUG]: create command list ..., inOrder: 1

one will see log like this:

<LEVEL_ZERO>[DEBUG]: create command list ..., inOrder: 1 <source/adapters/level_zero/v2/command_list_cache.cpp:73>

Review seems to be big but in fact is much shorter. The only essential change are some changes in

• ur_logger.hpp (removed unused functions)
• ur_logger_details.hpp (added macro, removed unused functions)
• ur_sinks.hpp parsing new env var parameter
• two lines in CMakeLists.txt

The rest was automated change of log statements from logger::xxx(...) to URLOG(XXX, ...)

[pbalcer]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

[lslusarczyk]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

My opinion is that filename and line number is crucial for efficient log analysis, unless you work for a long time in a project and perfectly know the code. When I realized UR don't have it I feel it is a must - hence the PR.

Still when writing a log statement one can write it in old way and in this case log statement will appear without line and number.

[pbalcer]

I don't know... This might be adding a lot of usually not needed noise to messages. I feel like this should be an option.

My opinion is that filename and line number is crucial for efficient log analysis, unless you work for a long time in a project and perfectly know the code. When I realized UR don't have it I feel it is a must - hence the PR.

Still when writing a log statement one can write it in old way and in this case log statement will appear without line and number.

Many of the logs, especially error/warning ones, aren't meant for developers, but for users. Anyway, I'm not opposed, but I think this should be an option.

[igchor]

@lslusarczyk I think some of the SYCL tests might rely on those log messages being in a specific format. I think you should either make this an option (like Piotr said) or run the tests and see if there are no failures.

[lslusarczyk]

@lslusarczyk I think some of the SYCL tests might rely on those log messages being in a specific format. I think you should either make this an option (like Piotr said) or run the tests and see if there are no failures.

@igchor , @pbalcer I've applied this suggestion. Now behavior does not change unless one will specify "fileline:1" when configuring logs via environment variable.

[martygrant]

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

---

This is an automated comment.