Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: several lambda quickstart improvements #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

w3dani
Copy link
Contributor

@w3dani w3dani commented Jan 3, 2023

What’s the focus of this PR

This PR includes some refactors on lambda handlers after some test usage (for example, adding middlewares, another way to organize multiple functions or input processing)

Includes a new schematics with a default set of github actions to deploy/destroy on aws with serverless

NOTE: I've found that serverless-offline (a very basic serverless plugin) is failing when license checking due to a dependency it has. I've removed it but we should take a look to this.

How to review this PR

Create a project with cli

Before submitting this PR, I made sure:

  • The code builds clean without any errors or warnings
  • I'm using our guidelines
  • I've added unit tests if feasible

Copy link

@jonastro jonastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants