Feat/add install packages schematic #93
Conversation
neodmy
requested review from
nanotower,
jonatan-martinez and
inigomarquinez
as code owners
| execSync('pnpm --version', {stdio: 'pipe'}); | ||
| return 'pnmp'; | ||
| } catch(e) { | ||
| return 'npm'; |
There was a problem hiding this comment.
I understand that by default it will use npm if it doesn't find anything. What happens if npm is not installed?
There was a problem hiding this comment.
And one more question. What happens if several of them are installed? We're giving preference to yarn.
There was a problem hiding this comment.
Preference is based on the lock file. If there is no lock file, it will explore the globally installed ones. In that case, yarn takes preference indeed. We can change it.
If the package manager is not installed, it will fail.
There was a problem hiding this comment.
I don't mind the order. I was just wondering if it's useful to have an optional config parameter to set the preference. Or perhaps I'm suggesting nonsense! 😬
There was a problem hiding this comment.
Do you mean to overwrite the discovered package manager?
|
After conversations with @inigomarquinez, we agreed not to have a schematic for installing packages. |
Description
Schematic to facilitate the installation of packages regardless of the project's package manager.
Related Issue
#95
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: