Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove package installation from schematics #96

Merged
merged 1 commit into from
Nov 24, 2023
Merged

refactor: remove package installation from schematics #96

merged 1 commit into from
Nov 24, 2023

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented Nov 24, 2023

Description

Remove package installation from schematics to simplify usage

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@neodmy neodmy self-assigned this Nov 24, 2023
inigomarquinez
inigomarquinez approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neodmy neodmy merged commit 1eec9b6 into main Nov 24, 2023
3 checks passed
@neodmy neodmy deleted the refactor/remove-package-installation branch November 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inigomarquinez inigomarquinez inigomarquinez approved these changes

@nanotower nanotower Awaiting requested review from nanotower nanotower is a code owner

@jonatan-martinez jonatan-martinez Awaiting requested review from jonatan-martinez jonatan-martinez is a code owner

Assignees

@neodmy neodmy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neodmy @inigomarquinez