Merge pull request #10 from oneblink/ON-16925

ON-16925 # Fixed replaceCustomValues only replacing element submissio…
oneblink · Nov 18, 2021 · 8c0632e · 8c0632e
2 parents e54be00 + f866560
commit 8c0632e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- `replaceCustomValues()` only replacing element submission data that is a string
+
 ## [0.2.4] - 2021-11-15
 
 ### Fixed

diff --git a/src/replaceCustomValues.ts b/src/replaceCustomValues.ts
@@ -81,7 +81,7 @@ export function getElementSubmissionValue({
   formatTime: (value: string) => string
   formatNumber: (value: number) => string
   formatCurrency: (value: number) => string
-}): string | undefined | Array<string> {
+}): unknown {
   const formElement = findFormElement(
     form.elements,
     (element) =>
@@ -212,7 +212,10 @@ function replaceElementValues(
       formatCurrency,
     })
 
-    return newString.replace(match, typeof value === 'string' ? value : '')
+    return newString.replace(
+      match,
+      value === undefined ? '' : (value as string),
+    )
   }, text)
 }