Add TrinoParquetFileReader to handle archived timelines parquet files#72
Open
voonhous wants to merge 1 commit intoonehouseinc:masterfrom
Open
Add TrinoParquetFileReader to handle archived timelines parquet files#72voonhous wants to merge 1 commit intoonehouseinc:masterfrom
voonhous wants to merge 1 commit intoonehouseinc:masterfrom
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/io/TrinoParquetFileReader.java
Outdated
Show resolved
Hide resolved
63021aa to
a8976ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug where a Hudi table with version 8 and an archived LSM timeline will become unreadable on trino.
We fix this by implementing
TrinoParquetFileReaderby extendingHoodieAvroFileReader.The main mechanism reuses
HudiAvroSerializerto convert aPage, which is created using Trino'sParquetReaderto create aCloseableIterator<IndexedRecord>to increase code reuse as much as possible.Additional context and related issues
error thrown:
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: