Add custom_attributes field support to User model #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling
list_users2()from the UsersV2Api, thecustom_attributesfield was not accessible on the returned User objects, even though the OneLogin API includes this data in responses. Users had to resort to workarounds like:This issue occurred because the
custom_attributesfield was not defined in the User model (onelogin/models/user.py).Solution
Added
custom_attributesas an optional dictionary field to the User model. Custom attributes are dynamic key-value pairs defined per OneLogin account, so they're represented asOptional[Dict[str, Any]].Changes:
custom_attributesfield to the User model with proper type annotations__propertieslist to include the new fieldfrom_dict()to parse custom_attributes from API responsesdocs/User.mdUsage
After this fix, custom attributes are directly accessible:
Testing
Fixes #107
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.