Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI with a matrix build #33

Merged
merged 17 commits into from
Jan 5, 2024
Merged

Add CircleCI with a matrix build #33

merged 17 commits into from
Jan 5, 2024

Conversation

vineelvineel
Copy link
Contributor

@vineelvineel vineelvineel commented Dec 14, 2023

Create a CircleCI config with a matrix build across several Ruby and Rails versions. See https://app.circleci.com/pipelines/github/onemedical/acts_as_scrubbable/39/workflows/836ee643-0005-40f2-8b6a-574b879a4e82 for an example!

Also included head for both Ruby and Rails to see what's failing on the next version. Currently the nulldb adapter doesn't support Rails 7.2, see nulldb/nulldb#128 for more information.

@vineelvineel vineelvineel self-assigned this Dec 14, 2023
@vineelvineel vineelvineel changed the title Circleci tests WIP: Circleci tests Dec 14, 2023
@adamstegman adamstegman force-pushed the circleci_tests branch 2 times, most recently from 432f2df to 5283d47 Compare January 4, 2024 15:25
@adamstegman adamstegman force-pushed the circleci_tests branch 11 times, most recently from 6e8ccaf to 020f8d2 Compare January 4, 2024 17:38
@adamstegman adamstegman force-pushed the circleci_tests branch 5 times, most recently from 922bc9b to ac2c8e0 Compare January 4, 2024 20:47
@adamstegman adamstegman force-pushed the circleci_tests branch 3 times, most recently from fababd6 to fb026f2 Compare January 4, 2024 23:25
@adamstegman adamstegman changed the title WIP: Circleci tests Add CircleCI with a matrix build Jan 4, 2024
@adamstegman adamstegman self-assigned this Jan 4, 2024
@adamstegman adamstegman marked this pull request as ready for review January 4, 2024 23:46
@adamstegman adamstegman requested a review from a team January 4, 2024 23:46
If head jobs fail, it's probably fine.
If released versions fail, it's an issue.
@adamstegman adamstegman merged commit d9d26e0 into main Jan 5, 2024
1 of 2 checks passed
@adamstegman adamstegman deleted the circleci_tests branch January 5, 2024 16:01
adamstegman added a commit that referenced this pull request Jan 5, 2024
Originally added in #30.
Removed in #33 because it was failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants