chore: notify when we need to add replacement to private method

addon/chrome/content/changecode.js

@@ -27,6 +27,9 @@ Tabmix.changeCode = function(aParent, afnName, aOptions) {
     } else {
       this.errMsg = "\n" + this.fullName + " is undefined.";
     }
+
+    this.verifyPrivateMethodReplaced();
+
     this.notFound.length = 0;
   }
 
@@ -35,6 +38,9 @@ Tabmix.changeCode = function(aParent, afnName, aOptions) {
     notFound: [],
     value: "",
     errMsg: "",
+    errMsgContent:
+      "\n\nTry Tabmix latest development version from https://bitbucket.org/onemen/tabmixplus-for-firefox/downloads/," +
+      "\nReport about this to Tabmix developer at https://github.com/onemen/TabMixPlus/issues",
     _replace: function TMP_utils__replace(substr, newString, aParams) {
       // Don't insert new code before "use strict";
       if (substr == "{") {
@@ -164,9 +170,7 @@ Tabmix.changeCode = function(aParent, afnName, aOptions) {
       if (notFoundCount && !this.silent) {
         let str = (notFoundCount > 1 ? "s" : "") + "\n    ";
         ex.message = ex.fnName + " was unable to change " + aName + "." +
-            (this.errMsg || "\ncan't find string" + str + this.notFound.join("\n    ")) +
-            "\n\nTry Tabmix latest development version from https://bitbucket.org/onemen/tabmixplus-for-firefox/downloads/," +
-            "\nReport about this to Tabmix developer at https://github.com/onemen/TabMixPlus/issues";
+            (this.errMsg || "\ncan't find string" + str + this.notFound.join("\n    ")) + this.errMsgContent;
         console.reportError(ex);
         if (debugMode) {
           console.clog(ex.fnName + "\nfunction " + aName + " = " + this.value, ex);
@@ -181,7 +185,24 @@ Tabmix.changeCode = function(aParent, afnName, aOptions) {
       let caller = (stack.caller || {}).caller || {};
       let {filename, lineNumber, columnNumber, name} = caller;
       return {filename, lineNumber, columnNumber, fnName: name, message: ""};
-    }
+    },
+
+    verifyPrivateMethodReplaced() {
+      const matches = this.value.match(/this\.#(\w+)/g);
+      if (!matches) {
+        return;
+      }
+      const privateMethods = new Set(matches.map(match => match.replace("this.#", "")));
+      const parentName = afnName.split(".").slice(0, -1).join(".");
+      const ex = this.getCallerData(Components.stack.caller);
+      for (const methods of privateMethods) {
+        if (typeof aParent[`_${methods}`] === "undefined") {
+          ex.message = `Implement replacement for private method #${methods} in ${parentName} it is used by ${this.fullName}${this.errMsgContent}`;
+          console.reportError(ex);
+        }
+      }
+      this.value = this.value.replace(/this\.#(\w+)/g, "this._$1");
+    },
   };
 
   try {

addon/chrome/content/minit/minit.js

@@ -62,6 +62,9 @@ var TMP_tabDNDObserver = {
         configurable: true,
         enumerable: true,
       });
+
+      // this function is just a place holder we don't use it in vertical mode
+      gBrowser.tabContainer._animateExpandedPinnedTabMove = function() {};
     }
 
     if (Tabmix.isVersion(1330)) {
@@ -180,8 +183,6 @@ var TMP_tabDNDObserver = {
       )._replace(
         /let lastTabCenter = (.*)tabSize \/ 2;/,
         'let lastTabCenter = $1(this.verticalMode ? tabSize / 2 : rightTabWidth / 2);'
-      )._replace(
-        /this\.#(\w*)/g, "this._$1", {check: Tabmix.isVersion(1310)}
       ).toCode();
     } else {
       // helper function to get floorp strings for width in vertical mode
@@ -243,8 +244,6 @@ var TMP_tabDNDObserver = {
          ? "translateY(" + Math.round(newMargin) + "px)"
          : "translate(" + Math.round(newMargin) + "px," + Math.round(newMarginY) + "px)";`,
       {check: Tabmix.isVersion(1300)}
-    )._replace(
-      /this\.#(\w*)/g, "this._$1", {check: Tabmix.isVersion(1310)}
     );
 
     const dropCode = Tabmix.changeCode(tabBar, "gBrowser.tabContainer.on_drop")._replace(
@@ -302,8 +301,6 @@ var TMP_tabDNDObserver = {
       } else {
         targetTab = null;
       }`
-    )._replace(
-      /this\.#(\w*)/g, "this._$1", {check: Tabmix.isVersion(1320)}
     );
 
     /**

addon/chrome/content/tab/scrollbox.js

@@ -185,11 +185,11 @@ Tabmix.multiRow = {
 
         const codeToReplace = Tabmix.isVersion(1310) ? 'this.#verticalMode' : 'this.getAttribute("orient") == "vertical"';
         Tabmix.changeCode(this, "scrollbox.on_touchstart")._replace(
-          codeToReplace, 'this._verticalMode'
+          codeToReplace, 'this._verticalMode', {silent: true}
         ).toCode();
 
         Tabmix.changeCode(this, "scrollbox.on_touchmove")._replace(
-          codeToReplace, 'this._verticalMode'
+          codeToReplace, 'this._verticalMode', {silent: true}
         ).toCode();
 
         this._scrollButtonUpLeft.addEventListener("contextmenu", this._createScrollButtonContextMenu, true);

addon/modules/log.jsm

@@ -343,7 +343,7 @@ const console = {
       if (typeof ex.filename == "undefined" && ex.fileName) {
         ex.filename = ex.fileName;
       }
-      if (!ex.filename || !ex.linenumber) {
+      if (!ex.filename || !ex.lineNumber) {
         caller = this.caller;
         ex.stack = caller.stack;
       }

types/extraTabmixUtils.d.ts

@@ -35,6 +35,7 @@ declare namespace ChangeCodeNS {
     type: "__lookupSetter__" | "__lookupGetter__";
     value: string;
     errMsg: string;
+    errMsgContent: string;
     notFound: (string | RegExp)[];
 
     prototype: ChangeCodeClass;
@@ -48,6 +49,7 @@ declare namespace ChangeCodeNS {
     show(aObj?: Record<string, unknown>, aName?: string): void;
     isValidToChange(this: ChangeCodeClass, aName: string): boolean;
     getCallerData(stack: nsIStackFrame, aOptions?: unknown): {filename: string; lineNumber: number; columnNumber: number; fnName: string; message: string};
+    verifyPrivateMethodReplaced(): void;
   }
 }
 

types/general.d.ts

@@ -208,6 +208,7 @@ declare namespace MockedGeckoTypes {
 
   interface TabContainer extends Element {
     _animateElement: ArrowScrollbox;
+    _animateExpandedPinnedTabMove: (event: MouseEvent) => void;
     _animateTabMove: (event: MouseEvent) => void;
     _backgroundTabScrollPromise?: Promise<void>;
     _blockDblClick?: boolean;