Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.1 #83

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Release/v3.1 #83

merged 2 commits into from
Jan 9, 2025

Conversation

YoussefDahi
Copy link
Contributor

No description provided.

* [Bug fix] fixed timeline graph no showing due to requests not having end value.
[Bug fix] replaced null end values showed detail subrequest tables

* console clean

* Fix: [inspect-app#80] clean code
…ail session page (#82)

- cards are loaded independently as soon as data is received
- added a loading indicator when getting the parent of session
- added a loafing indicator when getting db info in instance cards

additional changes:
- fixed a bug where parent session is not set to default after navigation
- fixed a bug where db info showed in instance card is not set to default after navigation
- clean consoles / unused imports
@YoussefDahi YoussefDahi added the bug Something isn't working label Jan 9, 2025
@YoussefDahi YoussefDahi added this to the backlog milestone Jan 9, 2025
@YoussefDahi YoussefDahi self-assigned this Jan 9, 2025
@usfalami usfalami removed the bug Something isn't working label Jan 9, 2025
Copy link
Contributor

@antonin77 antonin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
15.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@YoussefDahi YoussefDahi merged commit 3adf19c into main Jan 9, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants