Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge traces of a given environment over a specified period through the endpoint #103

Merged
merged 44 commits into from
Jan 3, 2025

Conversation

YoussefDahi
Copy link
Contributor

@YoussefDahi YoussefDahi commented Jan 2, 2025

fix: #81

@YoussefDahi YoussefDahi added the enhancement New feature or request label Jan 2, 2025
@YoussefDahi YoussefDahi requested a review from usfalami January 2, 2025 16:25
@YoussefDahi YoussefDahi self-assigned this Jan 2, 2025
@YoussefDahi YoussefDahi linked an issue Jan 2, 2025 that may be closed by this pull request
@usfalami
Copy link
Member

usfalami commented Jan 2, 2025

rename pr plz !

Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
50.0% Duplication on New Code (required ≤ 3%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

public boolean purgeData(String env, List<String> appName, Instant before, List<String> version) {

logger.log(Level.INFO, "+ Purging old Data, parameters in entry");
logger.log(Level.INFO, "\t- Environment: " + env);

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
@YoussefDahi YoussefDahi changed the title Purge endpoint Purge old data of a given environment through endpoint. Jan 3, 2025
@usfalami usfalami added this to the backlog milestone Jan 3, 2025
@usfalami usfalami changed the title Purge old data of a given environment through endpoint. Purge traces of a given environment over a specified period through the endpoint Jan 3, 2025
Copy link
Member

@usfalami usfalami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@usfalami usfalami merged commit 5ced51e into main Jan 3, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Purge endpoint
3 participants