Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charts toolbar parameter #22

Closed
wants to merge 4 commits into from

Conversation

NairodP
Copy link
Contributor

@NairodP NairodP commented Feb 5, 2025

In this pull request :

  • Update in jquery-core/src/lib/jquery-core.models.ts to add the parameter showToolbar in a newChart as well as in interfaces so that it is typed and integrated so that graphic components can access it via config.

  • Update all directives to add the showToolbar variable to _chartConfig, enabling or disabling the toolbar.

  • In updateConfig() of all directives, in options -> chart -> toolbar -> show: update so that the toolbar is set by default to the value given to it in config, otherwise to false. The toolbar is therefore invisible if it is not set to true in a chart's config when it is implemented.

implementation example :

pieExample:... = {
data: ...,
config: {
showToolbar: true,
... etc

Before :

pieExample:... = {
data: ...,
config: {
options: {
chart: {
toolbar: {
show: false
},
},
},
... etc

@NairodP NairodP linked an issue Feb 5, 2025 that may be closed by this pull request
@usfalami usfalami requested a review from antonin77 February 5, 2025 13:01
@NairodP NairodP closed this Feb 6, 2025
@NairodP NairodP deleted the add_charts_toolbar_parameter branch February 6, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add charts toolbar parameter
1 participant