Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable chart toolbar by default in chart directives and added a simple method for displaying or not the toolbar directly from a boolean in the configuration #29

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

NairodP
Copy link
Contributor

@NairodP NairodP commented Feb 6, 2025

This pull request introduces a new showToolbar configuration option across multiple chart directives to control the visibility of the toolbar in charts. The key changes include updates to the ChartProvider interface, modifications to various chart directive classes, and an example usage in the AppComponent.

Chart Configuration Enhancements:

Directive Updates:

Example Usage:

… simple method for displaying or not the toolbar directly from a boolean in the configuration.
@NairodP NairodP added the enhancement New feature or request label Feb 6, 2025
@NairodP NairodP linked an issue Feb 6, 2025 that may be closed by this pull request
@NairodP NairodP requested a review from antonin77 February 6, 2025 16:51
@NairodP NairodP self-assigned this Feb 6, 2025
@NairodP NairodP added this to the backlog milestone Feb 6, 2025
@usfalami usfalami removed this from the backlog milestone Feb 6, 2025
@NairodP NairodP merged commit f3f05c2 into oneteme:main Feb 10, 2025
1 check failed
@NairodP NairodP deleted the add_chart_toolbar_parameter_v2 branch February 10, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add charts toolbar parameter
3 participants