Add more built-in matchers to the Cadence Testing Framework #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2420 +/- ##
==========================================
- Coverage 78.60% 78.58% -0.02%
==========================================
Files 316 315 -1
Lines 68848 68886 +38
==========================================
+ Hits 54118 54135 +17
- Misses 12928 12943 +15
- Partials 1802 1808 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 tasks
m-Peter
commented
Apr 4, 2023
m-Peter
commented
Apr 4, 2023
SupunS
reviewed
Apr 6, 2023
This way it can be utilized in the test.cdc contract.
m-Peter
force-pushed
the
testing-framework-add-more-matchers
branch
from
ab8ee8c to
bad630c
Compare
turbolent
reviewed
Apr 7, 2023
turbolent
reviewed
Apr 7, 2023
SupunS
approved these changes
Apr 10, 2023
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
turbolent
reviewed
Apr 11, 2023
Comment on lines
+1574
to
+1578
| elementFound = value.ContainsKey( | ||
| inter, | ||
| invocation.LocationRange, | ||
| element, | ||
| ) |
There was a problem hiding this comment.
Yes, it seems that the Go implementation inspired by Hamcrest, has also dedicated matchers for arrays and dictionaries:
is.ArrayContaining(expected)is.ArrayMatching(expected)is.MapContaining(expected)is.MapContainingValues(expected)is.MapMatchingValues(expected)
Supun noted this as well. What do you think should be the way to go about this? Do you have any desired API in mind?
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: onflow/developer-grants#148
Description
Implements the matchers described in #1889
masterbranchFiles changedin the Github PR explorer