Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [typedefs] Switch interaction-related constants to enums #1816

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 27, 2023

follows up on #1802

@jribbink jribbink requested a review from a team as a code owner November 27, 2023 23:27
Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: 683e931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -24,18 +24,8 @@ const ACCT = `{
}
}`

const PRM = `{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The param resolver was removed a really long time ago, this is old/unused code

Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beauty!

@jribbink jribbink merged commit 83d4222 into master Nov 28, 2023
1 check passed
@jribbink jribbink deleted the jribbink/enum-convert branch November 28, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants