Skip to content

Add errors package to standardize error handling across the project #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add errors package to standardize error handling across the project #2065

wants to merge 2 commits into from
+60 −0

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Sep 15, 2025 •
edited
Loading

Closes #???

Description

Usage:

flowErrors.IsErrorType(err, flowErrors.StorageLimitExceeded)

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/errors/codes.go 0.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chasefleming chasefleming changed the title Introduce a dedicated errors package to centralize and standardize error handling across the project Add errors package to centralize and standardize error handling across the project Sep 15, 2025
@chasefleming chasefleming changed the title Add errors package to centralize and standardize error handling across the project Add errors package to standardize error handling across the project Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee will be requested when the pull request is marked ready for review Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf will be requested when the pull request is marked ready for review nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign will be requested when the pull request is marked ready for review bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek will be requested when the pull request is marked ready for review bjartek is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz will be requested when the pull request is marked ready for review mfbz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasefleming @codecov-commenter @jribbink