Skip to content

Kan/add signature sub command #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Kan/add signature sub command #2068

wants to merge 5 commits into from

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Sep 17, 2025

Closes #???

Description

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 3.84615% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/transactions/sign.go 5.35% 52 Missing and 1 partial ⚠️
internal/prompt/prompt.go 0.00% 16 Missing ⚠️
internal/transactions/transactions.go 0.00% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

chasefleming
chasefleming requested changes Sep 18, 2025
View reviewed changes
internal/transactions/add-sig.go Outdated

var addSigCommand = &command.Command{
Cmd: &cobra.Command{
Use: "add-sig <built transaction filename> <address> <signature>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the full use be add-signature and then have a shorthand for add-sig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming requested changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf will be requested when the pull request is marked ready for review nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign will be requested when the pull request is marked ready for review bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek will be requested when the pull request is marked ready for review bjartek is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink will be requested when the pull request is marked ready for review jribbink is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz will be requested when the pull request is marked ready for review mfbz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kay-Zee @codecov-commenter @chasefleming