Adds CrossVMMetadataViews to templates package #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
force-pushed
the
crossVMviews
branch
from
4cce55b to
3f68298
Compare
|
@sisyphusSmiling Can you give this a quick review? The changes are pretty minimal |
sisyphusSmiling
approved these changes
Mar 6, 2025
Comment on lines
+371
to
+377
| func ExampleToken(env templates.Environment) []byte { | ||
| return ftcontracts.ExampleToken(env.FungibleTokenAddress, env.MetadataViewsAddress, env.FungibleTokenMetadataViewsAddress) | ||
| } | ||
|
|
||
| func ExampleNFT(env templates.Environment) []byte { | ||
| return nftcontracts.ExampleNFTWithCrossVMPointers(flow.HexToAddress(env.NonFungibleTokenAddress), flow.HexToAddress(env.MetadataViewsAddress), flow.HexToAddress(env.ViewResolverAddress), flow.HexToAddress(env.EVMAddress), flow.HexToAddress(env.CrossVMMetadataViewsAddress)) | ||
| } |
There was a problem hiding this comment.
I'm assuming these are just added for testing?
There was a problem hiding this comment.
yeah, I added them so we could use them for testing in flow-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrossVMMetadataViewsplaceholders, address, and replacement to the templates package so that it can be used properly in flow-go and other places for bootstrapping and testing. Also adds it tocontractspackage.ExampleNFTandLinearAddressGeneratorto thecontractspackage.