Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Production Docker Registry environment for pushing to docker #6562

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Oct 11, 2024

This change will allow better control of the build process for containers.

Environments allow control over
a) Additional approval for usage of the environment/secrets, and
b) Allows admins to limit which branches can access the secrets

As of writing, the Production Docker Registry environment requires @Kay-Zee or @sjonpaulbrown approval to push to the docker registry, but this will be expanded once testing is complete.

Also, branches are limited to master and v0.37, which means we will have to update v0.37 to the new "active" branch whenever that happens. This should be exceedingly rare with our current release schedule.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.27%. Comparing base (c14ac33) to head (fbe32b5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6562      +/-   ##
==========================================
- Coverage   41.50%   41.27%   -0.24%     
==========================================
  Files        1935     2031      +96     
  Lines      137793   145883    +8090     
==========================================
+ Hits        57197    60208    +3011     
- Misses      74690    79454    +4764     
- Partials     5906     6221     +315     
Flag Coverage Δ
unittests 41.27% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjonpaulbrown sjonpaulbrown had a problem deploying to Production Docker Registry October 15, 2024 22:06 — with GitHub Actions Failure
@sjonpaulbrown sjonpaulbrown had a problem deploying to Production Docker Registry October 15, 2024 22:08 — with GitHub Actions Failure
@sjonpaulbrown sjonpaulbrown had a problem deploying to Production Docker Registry October 15, 2024 22:08 — with GitHub Actions Failure
@sjonpaulbrown
Copy link
Collaborator

The protection rules for the environment will ensure that the workflow can only be executed from the specified branches, but it will not enforce that a specific tag cannot be built. If the intention is to "block" any tags or branches that are not master or v0.37, this will not work as the workflow takes an input that is used to dynamically checkout the repo. If we want to automatically enforce this, we would need to restructure the workflows.

As long as we are ok with this being the responsibility of the reviewer, this should be ok, but I did want to call out that the enforcement of this will not be automatic.

@sjonpaulbrown sjonpaulbrown had a problem deploying to Production Docker Registry October 15, 2024 22:26 — with GitHub Actions Failure
@Kay-Zee
Copy link
Member Author

Kay-Zee commented Oct 15, 2024

I will likely change this setup to no longer be manual dispatch, and only work off the two "active" branches. The manual setup is mostly for testing purposes. We can discuss if we want to keep the manual or go back to the auto build based on tag, but i'm inclined for the latter. At least for the CD workflow.

@Kay-Zee Kay-Zee added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 3ba181e Oct 15, 2024
60 of 64 checks passed
@Kay-Zee Kay-Zee deleted the kan/add-docker-push-environment branch October 15, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants