-
Notifications
You must be signed in to change notification settings - Fork 195
[Access] Implement subscribe transaction statuses by transaction ID #6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement subscribe transaction statuses by transaction ID #6737
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6737 +/- ##
==========================================
+ Coverage 41.26% 41.27% +0.01%
==========================================
Files 2159 2160 +1
Lines 189425 189388 -37
==========================================
+ Hits 78171 78178 +7
+ Misses 104738 104689 -49
- Partials 6516 6521 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few small comments, but otherwise looks good
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple more comments, but otherwise looks good.
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than missing irrecoverable error
…isarchuk/6573-pending-should-return-immediately
…isarchuk/6573-pending-should-return-immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally finished the review. Thank you for hard work, I've left some comments regarding error handling and processing of inputs. Let me know if you would like to discuss any of them. Otherwise, good job!
engine/access/rest/websockets/data_providers/transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
engine/access/rest/websockets/data_providers/transaction_statuses_provider.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com>
Co-authored-by: Yurii Oleksyshyn <yuraolex@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few small comments, but otherwise this looks good. Thanks for all your work on this!
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Closes #6573 and #6574
This PR implements a new subscription to a transaction by txID and changes the existing send and subscribe endpoint.
This PR introduces a separate
transactionSubscriptionMetadata
private module and moves the handling of transactions status logic there to simplify streaming module logic.