Skip to content

[Access] Implement subscribe transaction statuses by transaction ID #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Guitarheroua
Copy link
Contributor

@Guitarheroua Guitarheroua commented Nov 19, 2024

Closes #6573 and #6574

This PR implements a new subscription to a transaction by txID and changes the existing send and subscribe endpoint.

This PR introduces a separate transactionSubscriptionMetadata private module and moves the handling of transactions status logic there to simplify streaming module logic.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 69.43231% with 70 lines in your changes missing coverage. Please review.

Project coverage is 41.27%. Comparing base (db2177b) to head (c03a846).

Files with missing lines Patch % Lines
...s/rpc/backend/transaction_subscription_metadata.go 62.50% 32 Missing and 10 partials ⚠️
.../access/rpc/backend/backend_stream_transactions.go 72.88% 12 Missing and 4 partials ⚠️
access/api.go 0.00% 4 Missing ⚠️
access/mock/api.go 0.00% 2 Missing ⚠️
cmd/util/cmd/run-script/cmd.go 0.00% 2 Missing ⚠️
...ts/data_providers/transaction_statuses_provider.go 83.33% 2 Missing ⚠️
engine/access/rpc/backend/backend_transactions.go 83.33% 1 Missing ⚠️
...ss/rpc/backend/transactions_local_data_provider.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
+ Coverage   41.26%   41.27%   +0.01%     
==========================================
  Files        2159     2160       +1     
  Lines      189425   189388      -37     
==========================================
+ Hits        78171    78178       +7     
+ Misses     104738   104689      -49     
- Partials     6516     6521       +5     
Flag Coverage Δ
unittests 41.27% <69.43%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Guitarheroua Guitarheroua self-assigned this Nov 20, 2024
@Guitarheroua Guitarheroua marked this pull request as ready for review November 21, 2024 07:42
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few small comments, but otherwise looks good

Guitarheroua and others added 2 commits December 20, 2024 11:33
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple more comments, but otherwise looks good.

peterargue
peterargue previously approved these changes Dec 27, 2024
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than missing irrecoverable error

@peterargue peterargue requested a review from durkmurder January 2, 2025 17:55
@Guitarheroua Guitarheroua requested a review from a team as a code owner January 16, 2025 08:02
Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally finished the review. Thank you for hard work, I've left some comments regarding error handling and processing of inputs. Let me know if you would like to discuss any of them. Otherwise, good job!

Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few small comments, but otherwise this looks good. Thanks for all your work on this!

@Guitarheroua Guitarheroua added this pull request to the merge queue Mar 6, 2025
Merged via the queue into onflow:master with commit 93369df Mar 6, 2025
56 checks passed
@Guitarheroua Guitarheroua deleted the AndriiSlisarchuk/6573-pending-should-return-immediately branch March 6, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Pending response from send and subscribe should return immediately
4 participants