[Access] Fix access connection tests for latest version of testing library #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
commented
Jan 17, 2025
| @@ -674,10 +657,6 @@ func TestEvictingCacheClients(t *testing.T) { | |||
| func(context.Context, *access.PingRequest) error { return nil }, | |||
| ) | |||
|
|
|||
| netReq := &access.GetNetworkParametersRequest{} | |||
| netResp := &access.GetNetworkParametersResponse{} | |||
| cn.handler.On("GetNetworkParameters", testifymock.Anything, netReq).Return(netResp, nil) | |||
There was a problem hiding this comment.
this was not used and isn't needed for the test
peterargue
commented
Jan 17, 2025
| @@ -749,9 +728,7 @@ func TestEvictingCacheClients(t *testing.T) { | |||
|
|
|||
| // Call a gRPC method on the client | |||
| _, err = client.Ping(ctx, pingReq) | |||
| // Check that Ping was called | |||
| cn.handler.AssertCalled(t, "Ping", testifymock.Anything, pingReq) | |||
There was a problem hiding this comment.
these asserts are called automatically now for the collection and execution mock clients
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
- Coverage 41.09% 41.08% -0.01%
==========================================
Files 2121 2121
Lines 185912 185922 +10
==========================================
- Hits 76395 76386 -9
- Misses 103104 103119 +15
- Partials 6413 6417 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures from https://github.com/onflow/flow-go/actions/runs/12402358137/job/34623739390?pr=6779
Needed to merge #6779 which upgrades the testify library