Refactor the remote debugger and add support for using the execution data API #6929
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6929 +/- ##
==========================================
- Coverage 41.08% 41.06% -0.03%
==========================================
Files 2119 2120 +1
Lines 185893 186100 +207
==========================================
+ Hits 76383 76426 +43
- Misses 103105 103261 +156
- Partials 6405 6413 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
though the blocks are unavailable, the block header is provided. this allows us to at least to provide the current block info
turbolent
requested review from
janezpodhostnik and
zhangchiqing
as code owners
| if info.blocks == nil { | ||
| return runtime.Block{}, false, errors.NewOperationNotSupportedError( | ||
| "GetBlockAtHeight") | ||
| } | ||
|
|
There was a problem hiding this comment.
Move this check after the use of info.blockHeader, which is set in the remote debugger
| } | ||
| } | ||
|
|
||
| func sortRegisters(registerIDs []flow.RegisterID) { |
There was a problem hiding this comment.
Note (for future expansion): I actually often find it most useful to have the registers sorted in read order for debugging. However currently that ordering is lost because we put the reads in a map.
|
@janezpodhostnik Added support for running "mid-block" transactions in 15f26d2. Can you please take another look and let me know if that looks right? Thanks! |
getCurrentBlock()calls